expose buildId to custom webpack configs #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested changes
Sep 27, 2017
Looks good! we should document it in the readme though. Here: https://github.com/zeit/next.js#customizing-webpack-config
|
Done and done! |
|
Thanks! |
chuyik
pushed a commit
to chuyik/next.js
that referenced
this issue
Oct 19, 2017
* expose buildId to custom webpack configs * update readme to include buildId in option object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It's useful to have the buildId in the custom webpack configuration.
Our specific use case is that we're using https://github.com/jmshal/webpack-bugsnag-plugin to automatically upload our sourcemap to bugsnag on build. To do that, we need to provide an "appVersion" (buildId basically), and that "appVersion" needs to be the same value that we provide to the bugsnag library when we initialize it on app start (we do this in _document.js). We are already using buildId in to initialize bugsnag on app start, so this would tie the two together and allow us to connect source maps with specific production builds.
I'm sure there are other use cases as well!