Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Improve ReasonML example #3021

Merged
merged 8 commits into from Sep 30, 2017
Merged

Conversation

nrako
Copy link
Contributor

@nrako nrako commented Sep 30, 2017

This improve the example for ReasonML with-reasonml.

While trying to run this example, I run into different issues, this PR is meant to fix them. While at it, this also upgrade some dependencies, including upgrading to next.js v3. And make some other improvements, enable nicer error msgs and update the example to use the new recommended ReasonReact.reducerComponent instead of ReasonReact.statefulComponent - more read about this here.

Note: I believe that the package-lock.json should be versioned in the examples, especially for theses kind of example which use "bleeding edge" stuff prone to break at any new deps update. However, #2623 ignore them, not sure why, so I didn't add the file.

@nrako
Copy link
Contributor Author

@nrako nrako commented Sep 30, 2017

@mike-engel since you first pushed the initial example for ReasonML/ReactReason, I'd love to have your input on this. I'm just starting with ReasonML.

Copy link

@mike-engel mike-engel left a comment

👍 LGTM

@timneutkens timneutkens merged commit 016920e into vercel:master Sep 30, 2017
3 checks passed
@timneutkens
Copy link
Member

@timneutkens timneutkens commented Sep 30, 2017

Thanks guys!

@nrako
Copy link
Contributor Author

@nrako nrako commented Sep 30, 2017

With pleasure!

@hsavit1
Copy link

@hsavit1 hsavit1 commented Oct 31, 2017

please upgrade to reasonml 3

@lock
Copy link

@lock lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants