Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace case with tsconfig/jsconfig baseUrl #30286

Merged
merged 2 commits into from Oct 25, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 25, 2021

This ensures we resolves files using baseUrl correctly and adds tests for both only baseUrl being configured and baseUrl + paths.

Fixes: #30279

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

styfle
styfle approved these changes Oct 25, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 25, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
buildDuration 20.3s 19.9s -338ms
buildDurationCached 4.1s 4.1s ⚠️ +53ms
nodeModulesSize 475 MB 475 MB ⚠️ +130 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
/ failed reqs 0 0
/ total time (seconds) 3.396 3.308 -0.09
/ avg req/sec 736.26 755.63 +19.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.58 1.551 -0.03
/error-in-render avg req/sec 1582.49 1611.44 +28.95
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
buildDuration 16.9s 17.2s ⚠️ +289ms
buildDurationCached 4.1s 4s -44ms
nodeModulesSize 475 MB 475 MB ⚠️ +130 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
/ failed reqs 0 0
/ total time (seconds) 3.365 3.42 ⚠️ +0.05
/ avg req/sec 742.92 730.93 ⚠️ -11.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.618 1.578 -0.04
/error-in-render avg req/sec 1545.53 1584.75 +39.22
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/tsconfig-resolves Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: ac61974

@ijjk ijjk merged commit 73fbd69 into vercel:canary Oct 25, 2021
32 of 33 checks passed
@ijjk ijjk deleted the fix/tsconfig-resolves branch October 25, 2021 23:38
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest canary breaks the @prisma/client module
2 participants