Chore/publish all swc #30289

padmaia · 2021-10-26T01:27:45Z

This moves the extra swc targets to the build-test-deploy publish flow as the build-native which commits the binaries is only meant to ease development for contributors and the vast majority of them only need the 4 binaries we are already committing.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk

Thanks! 🙌

padmaia · 2021-10-26T01:31:34Z

.github/workflows/build_test_deploy.yml

@@ -514,7 +524,7 @@ jobs:
        uses: actions/cache@v2
        if: ${{ steps.docs-change.outputs.DOCS_CHANGE != 'docs only change' }}
        with:
-          path: packages/next/native/next-swc.*.node
+          path: packages/next/native/next-swc.${{ matrix.name }}.node


This wasn't causing any problems, but will make the caches smaller.

ijjk · 2021-10-26T01:33:12Z

.github/workflows/build_test_deploy.yml

+      - build-linux-arm7
+      - build-linux-aarch64
+      - build-android-aarch64
+      - build-freebsd


It looks like this job is missing:

The workflow is not valid. .github/workflows/build_test_deploy.yml (Line: 420, Col: 9): Job 'publishRelease' depends on unknown job 'build-freebsd'. .github/workflows/build_test_deploy.yml (Line: 445, Col: 13): Job 'releaseStats' depends on job 'publishRelease' which creates a cycle in the dependency graph.

Oh right, I'll remove it. It was silently failing in the build_native workflow, so we still need to add this one later. cc @kdy1

ijjk · 2021-10-26T01:52:10Z

Failing test suites

Commit: 73f7ae7

test/development/basic/hmr.test.ts

basic HMR > Error Recovery > should recover after exporting an invalid page
basic HMR > Error Recovery > should recover after undefined exported as default

Expand output

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:524:9)

● basic HMR › Error Recovery › should recover after undefined exported as default

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:628:8)

ijjk · 2021-10-26T01:54:27Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
buildDuration	20.8s	20.5s	-264ms
buildDurationCached	4s	4.2s	⚠️ +211ms
nodeModulesSize	475 MB	198 MB	-277 MB

Page Load Tests Overall increase ✓

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.662	3.708	⚠️ +0.05
/ avg req/sec	682.61	674.13	⚠️ -8.48
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.043	1.926	-0.12
/error-in-render avg req/sec	1223.74	1297.93	+74.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.7 kB	27.7 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.5 kB	71.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
index.html gzip	533 B	533 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
buildDuration	17.6s	17.2s	-329ms
buildDurationCached	4.1s	4.2s	⚠️ +150ms
nodeModulesSize	475 MB	198 MB	-277 MB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.663	3.728	⚠️ +0.07
/ avg req/sec	682.42	670.69	⚠️ -11.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.868	1.868	✓
/error-in-render avg req/sec	1338.53	1338.22	⚠️ -0.31

Client Bundles (main, webpack, commons)

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.8 kB	27.8 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	621 B	621 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.9 kB	1.9 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	padmaia/next.js chore/publish-all-swc	Change
index.html gzip	534 B	534 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	528 B	528 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 73f7ae7

padmaia and others added 4 commits October 25, 2021 17:53

Publish more swc targets

8c889a1

Remove prebuilt binaries

72b9ca8

Use correct path for caching

fac52ec

Build next-swc binaries

f9d4d8f

padmaia requested review from huozhi, ijjk, shuding, styfle and timneutkens as code owners October 26, 2021 01:27

Merge branch 'canary' into chore/publish-all-swc

635bafb

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 26, 2021

ijjk previously approved these changes Oct 26, 2021

View reviewed changes

padmaia commented Oct 26, 2021

View reviewed changes

ijjk reviewed Oct 26, 2021

View reviewed changes

Remove unused job dependency

73f7ae7

padmaia dismissed ijjk’s stale review via 73f7ae7 October 26, 2021 01:37

ijjk approved these changes Oct 26, 2021

View reviewed changes

padmaia merged commit 20da807 into vercel:canary Oct 26, 2021

padmaia deleted the chore/publish-all-swc branch October 26, 2021 02:00

styfle added the hacktoberfest-accepted label Oct 31, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/publish all swc #30289

Chore/publish all swc #30289

padmaia commented Oct 26, 2021

ijjk left a comment

padmaia Oct 26, 2021

ijjk Oct 26, 2021

padmaia Oct 26, 2021

ijjk commented Oct 26, 2021

ijjk commented Oct 26, 2021

Chore/publish all swc #30289

Chore/publish all swc #30289

Conversation

padmaia commented Oct 26, 2021

Bug

Feature

Documentation / Examples

ijjk left a comment

Choose a reason for hiding this comment

padmaia Oct 26, 2021

Choose a reason for hiding this comment

ijjk Oct 26, 2021

Choose a reason for hiding this comment

padmaia Oct 26, 2021

Choose a reason for hiding this comment

ijjk commented Oct 26, 2021

Failing test suites

ijjk commented Oct 26, 2021

Stats from current PR