Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track usage of swc features #30297

Merged
merged 3 commits into from Oct 26, 2021
Merged

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Oct 26, 2021

Related PR: https://github.com/vercel/next-telemetry/pull/55

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
buildDuration 17.3s 17.3s ⚠️ +29ms
buildDurationCached 3.5s 3.6s ⚠️ +34ms
nodeModulesSize 198 MB 198 MB ⚠️ +1.3 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
/ failed reqs 0 0
/ total time (seconds) 2.886 2.879 -0.01
/ avg req/sec 866.13 868.3 +2.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.417 1.461 ⚠️ +0.04
/error-in-render avg req/sec 1763.86 1710.72 ⚠️ -53.14
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
buildDuration 14.8s 14.7s -81ms
buildDurationCached 3.5s 3.8s ⚠️ +270ms
nodeModulesSize 198 MB 198 MB ⚠️ +1.3 kB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
/ failed reqs 0 0
/ total time (seconds) 2.87 2.9 ⚠️ +0.03
/ avg req/sec 871.11 861.97 ⚠️ -9.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.393 1.352 -0.04
/error-in-render avg req/sec 1794.64 1848.5 +53.86
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/track-swc-usage Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 89b6ba2

@ijjk
Copy link
Member

ijjk commented Oct 26, 2021

Failing test suites

Commit: 89b6ba2

test/integration/preload-viewport/test/index.test.js

  • Prefetching Links in viewport > should not prefetch already loaded scripts
Expand output

● Prefetching Links in viewport › should not prefetch already loaded scripts

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  397 |     expect(hrefs).toEqual([...new Set(hrefs)])
  398 |
> 399 |     // Verify encoding
      |     ^
  400 |     expect(hrefs.some((e) => e.includes(`%5Bhello%5D-`))).toBe(true)
  401 |   })
  402 |

  at Object.<anonymous> (integration/preload-viewport/test/index.test.js:399:5)

test/integration/telemetry/test/index.test.js

  • Telemetry CLI > emits telemery for usage of image, script & dynamic
Expand output

● Telemetry CLI › emits telemery for usage of image, script & dynamic

expect(received).toContain(expected) // indexOf

Expected substring: "\"featureName\": \"next/image\""
Received string:    "
    \"featureName\": \"swcLoader\",
    \"invocationCount\": 1
  "

  571 |     regex.exec(stderr).pop() // optimizeCss
  572 |     const image = regex.exec(stderr).pop()
> 573 |     expect(image).toContain(`"featureName": "next/image"`)
      |                   ^
  574 |     expect(image).toContain(`"invocationCount": 1`)
  575 |     const script = regex.exec(stderr).pop()
  576 |     expect(script).toContain(`"featureName": "next/script"`)

  at Object.<anonymous> (integration/telemetry/test/index.test.js:573:19)

timneutkens
timneutkens previously approved these changes Oct 26, 2021
@timneutkens timneutkens merged commit 0ab8c7a into vercel:canary Oct 26, 2021
10 of 12 checks passed
@timneutkens timneutkens deleted the add/track-swc-usage branch October 26, 2021 07:37
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants