Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc to onDemandEntries configuration #3030

Merged
merged 2 commits into from Oct 5, 2017

Conversation

AugustinLF
Copy link
Contributor

@AugustinLF AugustinLF commented Oct 2, 2017

I didn't add docs when adding the pagesBufferLength option. Since maxInactiveAge was not documented either, this is a PR for both options.

readme.md Outdated
module.exports = {
onDemandEntries: {
// period where the server will keep pages in the buffer, defaults to 25s
maxInactiveAge,
Copy link
Member

@timneutkens timneutkens Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do maxInactiveAge: 25 etc 😄

Copy link
Contributor Author

@AugustinLF AugustinLF Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I amended the commit!

module.exports = {
onDemandEntries: {
// period (in ms) where the server will keep pages in the buffer
maxInactiveAge: 25 * 1000,
Copy link
Member

@timneutkens timneutkens Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks much better 💯 ❤️

Copy link
Member

@timneutkens timneutkens left a comment

Thanks! ❤️

@timneutkens timneutkens merged commit 285b27b into vercel:master Oct 5, 2017
3 checks passed
@AugustinLF AugustinLF deleted the doc/onDemandEntries branch Oct 5, 2017
@lock
Copy link

@lock lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants