Add doc to onDemandEntries configuration #3030
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Oct 2, 2017
readme.md
Outdated
| module.exports = { | ||
| onDemandEntries: { | ||
| // period where the server will keep pages in the buffer, defaults to 25s | ||
| maxInactiveAge, |
There was a problem hiding this comment.
Lets do maxInactiveAge: 25 etc
There was a problem hiding this comment.
I amended the commit!
timneutkens
reviewed
Oct 2, 2017
| module.exports = { | ||
| onDemandEntries: { | ||
| // period (in ms) where the server will keep pages in the buffer | ||
| maxInactiveAge: 25 * 1000, |
There was a problem hiding this comment.
Awesome, this looks much better
timneutkens
approved these changes
Oct 2, 2017
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I didn't add docs when adding the
pagesBufferLengthoption. SincemaxInactiveAgewas not documented either, this is a PR for both options.