Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure null bytes in resolved path are handled #30313

Merged
merged 1 commit into from Oct 26, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2021

This ensures we remove null bytes from the resolved path as it isn't valid when using path/fs. Additional tests have been added to ensure this is handled properly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #30298

@ijjk ijjk added created-by: Next.js team type: next labels Oct 26, 2021
@ijjk ijjk marked this pull request as ready for review Oct 26, 2021
@ijjk
Copy link
Member Author

@ijjk ijjk commented Oct 26, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
buildDuration 21.3s 21.6s ⚠️ +323ms
buildDurationCached 4.5s 4.2s -346ms
nodeModulesSize 198 MB 198 MB ⚠️ +120 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
/ failed reqs 0 0
/ total time (seconds) 3.757 3.864 ⚠️ +0.11
/ avg req/sec 665.44 647.05 ⚠️ -18.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.188 2.154 -0.03
/error-in-render avg req/sec 1142.7 1160.79 +18.09
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
buildDuration 18.9s 18.9s
buildDurationCached 4.5s 4.4s -36ms
nodeModulesSize 198 MB 198 MB ⚠️ +120 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
/ failed reqs 0 0
/ total time (seconds) 3.819 3.902 ⚠️ +0.08
/ avg req/sec 654.61 640.64 ⚠️ -13.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.004 2.04 ⚠️ +0.04
/error-in-render avg req/sec 1247.45 1225.72 ⚠️ -21.73
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/trace-null-bytes Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 0cb4d05

@kodiakhq kodiakhq bot merged commit 8b85801 into vercel:canary Oct 26, 2021
39 checks passed
@ijjk ijjk deleted the fix/trace-null-bytes branch Oct 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants