Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation errors for new middleware API #30316

Merged
merged 6 commits into from Oct 26, 2021

Conversation

javivelasco
Copy link
Member

This improves the deprecation error for the previous Middleware API

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

errors/middleware-new-signature.md Outdated Show resolved Hide resolved
errors/middleware-new-signature.md Outdated Show resolved Hide resolved
errors/middleware-new-signature.md Outdated Show resolved Hide resolved
javivelasco and others added 2 commits October 26, 2021 16:30
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
packages/next/server/web/error.ts Outdated Show resolved Hide resolved
@timneutkens timneutkens merged commit c497b3a into vercel:canary Oct 26, 2021
8 of 12 checks passed
@javivelasco javivelasco deleted the improve-deprecation-errors branch November 3, 2021 07:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants