Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-firebase-hosting. #3032

Merged
merged 2 commits into from Oct 5, 2017
Merged

Update with-firebase-hosting. #3032

merged 2 commits into from Oct 5, 2017

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Oct 2, 2017

Use Next v4 and React16.

Simplify npm scripts as per discussion #2763 (remove npm i from local development script)

Closes #2763

Uses next@beta so might not want to merge immediately.

Simplify scripts.
Copy link
Member

@timneutkens timneutkens left a comment

v4 will be out soon, please send a follow up PR when it's out 😄 I'll merge this when the tests pass

@jthegedus jthegedus changed the title Use Next v4 and React16. Update with-firebase-hosting. Oct 2, 2017
@jthegedus
Copy link
Contributor Author

@jthegedus jthegedus commented Oct 2, 2017

I'm keen for v4! 😄

@timneutkens timneutkens merged commit 594b214 into vercel:master Oct 5, 2017
3 checks passed
@timneutkens
Copy link
Member

@timneutkens timneutkens commented Oct 5, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants