Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-mongo example by removing deprecated function #30675

Merged
merged 6 commits into from Nov 30, 2021
Merged

Fix with-mongo example by removing deprecated function #30675

merged 6 commits into from Nov 30, 2021

Conversation

iicdii
Copy link
Contributor

@iicdii iicdii commented Oct 30, 2021 •
edited

Documentation / Examples

  • Make sure the linting passes

It fixes #30651.

What I did

@ijjk ijjk added the examples Issue/PR related to examples label Oct 30, 2021
@iicdii iicdii changed the title Fix depreacted function Fix mongo example by removing deprecated function Oct 30, 2021
@iicdii iicdii changed the title Fix mongo example by removing deprecated function Fix with-mongo example by removing deprecated function Oct 30, 2021
EugeneGohh
EugeneGohh previously approved these changes Oct 31, 2021
View reviewed changes
Copy link

@EugeneGohh EugeneGohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@iicdii
Copy link
Contributor Author

iicdii commented Nov 23, 2021

@ijjk Any news? I'm waiting for approve 🙂

ijjk
ijjk previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk dismissed stale reviews from EugeneGohh and themself via 16e0e0d November 30, 2021 21:38
@ijjk ijjk merged commit b290a3d into vercel:canary Nov 30, 2021
@iicdii iicdii deleted the fix-depreacted-function branch December 1, 2021 00:32
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@EugeneGohh EugeneGohh EugeneGohh left review comments

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update MongoDB Next.js Template
3 participants
@iicdii @ijjk @EugeneGohh