Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NextResponse default redirect status to 307 to match docs #33505

Merged
merged 4 commits into from
Feb 1, 2022
Merged

update NextResponse default redirect status to 307 to match docs #33505

merged 4 commits into from
Feb 1, 2022

Conversation

sean6bucks
Copy link
Contributor

According to the next/server documentation on redirects, it has a whole section how 307 and 308 are the preferred redirect statuses for redirects and the default for NextResponse.redirect() has been updated to use 307, however the code is still setting 302 status code as its default.

This PR updates the default status argument value for NextResponse.redirect to the 307 temporary redirect status code as expected according to the documentation.

Bug

  • Related issues linked using fixes #number N/A
  • Integration tests added: No tests for NextResponse class found
  • Errors have helpful link attached, see contributing.md

@sean6bucks sean6bucks changed the title update default redirect status to 307 to match docs update NextResponse default redirect status to 307 to match docs Jan 20, 2022
@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good as we definitely want to prefer 307 over 302 similar to our redirects in next.config.js. Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Feb 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
buildDuration 16.8s 17.2s ⚠️ +396ms
buildDurationCached 4.3s 4.4s ⚠️ +138ms
nodeModulesSize 359 MB 359 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.105 4.248 ⚠️ +0.14
/ avg req/sec 608.96 588.53 ⚠️ -20.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.113 2.29 ⚠️ +0.18
/error-in-render avg req/sec 1182.94 1091.91 ⚠️ -91.03
Client Bundles (main, webpack, commons)
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.1 kB 71.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
index.html gzip 529 B 529 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
buildDuration 21.5s 21.5s -50ms
buildDurationCached 4.2s 4.2s ⚠️ +32ms
nodeModulesSize 359 MB 359 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.116 4.208 ⚠️ +0.09
/ avg req/sec 607.4 594.07 ⚠️ -13.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.183 2.174 -0.01
/error-in-render avg req/sec 1145.42 1150.07 +4.65
Client Bundles (main, webpack, commons)
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.4 kB 27.4 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.98 kB 4.98 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary sean6bucks/next.js update-default-server-redirect-status-code Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: b58e12b

@ijjk ijjk merged commit 5d9310e into vercel:canary Feb 1, 2022
@sean6bucks sean6bucks deleted the update-default-server-redirect-status-code branch February 3, 2022 07:40
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@sean6bucks @ijjk @natew
update NextResponse default redirect status to 307 to match docs (ver…
2380bcc 
…cel#33505)

* fix: update default redirect status to 307 to match docs

* fix: update default redirect status to 307 to match docs

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean6bucks @ijjk