Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor page component getter in web server #33759

Merged
merged 5 commits into from Feb 1, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Jan 28, 2022

Cleans up the code of the middleware SSR loader and the web server. Currently the page components and render options are provided to the server via globalThis which is not ideal.

Instead we can inject extendRenderOpts and loadComponent to the web server. Since this is the the minimal mode and we'll need to handle ?flight requests, we update the server render opts upon updateRenderOpts (In the future this should be changed to be passed to requestHandler to avoid race conditions).

Currently, we can't fully get rid of the __server_context global as we call getBuildId in the base server constructor.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

huozhi
huozhi approved these changes Feb 1, 2022
ijjk
ijjk approved these changes Feb 1, 2022
@ijjk
Copy link
Member

ijjk commented Feb 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/f89e Change
buildDuration 12.5s 12.4s -29ms
buildDurationCached 3s 3.2s ⚠️ +182ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.51 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/f89e Change
/ failed reqs 0 0
/ total time (seconds) 2.892 2.918 ⚠️ +0.03
/ avg req/sec 864.4 856.76 ⚠️ -7.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.345 1.386 ⚠️ +0.04
/error-in-render avg req/sec 1858.45 1803.27 ⚠️ -55.18
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/f89e Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/f89e Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/f89e Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/f89e Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/f89e Change
index.html gzip 529 B 529 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/f89e Change
buildDuration 16s 15.8s -182ms
buildDurationCached 3.2s 3.2s ⚠️ +26ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.51 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/f89e Change
/ failed reqs 0 0
/ total time (seconds) 2.939 2.956 ⚠️ +0.02
/ avg req/sec 850.69 845.69 ⚠️ -5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.383 1.359 -0.02
/error-in-render avg req/sec 1807.52 1839.65 +32.13
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/f89e Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/f89e Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/f89e Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/f89e Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/f89e Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 14bc592

@kodiakhq kodiakhq bot merged commit 51f0359 into vercel:canary Feb 1, 2022
40 of 42 checks passed
@shuding shuding deleted the shu/f89e branch Feb 1, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
Cleans up the code of the middleware SSR loader and the web server. Currently the page components and render options are provided to the server via `globalThis` which is not ideal.

Instead we can inject `extendRenderOpts` and `loadComponent` to the web server. Since this is the the minimal mode and we'll need to handle `?flight` requests, we update the server render opts upon `updateRenderOpts` (In the future this should be changed to be passed to `requestHandler` to avoid race conditions).

Currently, we can't fully get rid of the `__server_context` global as we call `getBuildId` in the base server constructor.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants