Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack #33831

Merged
merged 4 commits into from Feb 1, 2022
Merged

update webpack #33831

merged 4 commits into from Feb 1, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 31, 2022

@ijjk ijjk added created-by: Next.js team type: next labels Jan 31, 2022
@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review Feb 1, 2022
ijjk
ijjk approved these changes Feb 1, 2022
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 1, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 14.5s 13.6s -889ms
buildDurationCached 3.3s 3.2s -32ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.35 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 5.799 3.639 -2.16
/ avg req/sec 431.1 686.95 +255.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.433 1.422 -0.01
/error-in-render avg req/sec 1744.22 1757.97 +13.75
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 16.6s 18.9s ⚠️ +2.3s
buildDurationCached 3.2s 3.4s ⚠️ +139ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.35 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0
/ total time (seconds) 3.115 2.954 -0.16
/ avg req/sec 802.59 846.24 +43.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.436 1.425 -0.01
/error-in-render avg req/sec 1741.31 1753.95 +12.64
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 5b7a0d9

@kodiakhq kodiakhq bot merged commit 3ba3bb8 into canary Feb 1, 2022
40 of 42 checks passed
@kodiakhq kodiakhq bot deleted the webpack/update branch Feb 1, 2022
@marnixhoh
Copy link

@marnixhoh marnixhoh commented Feb 2, 2022

In case someone else runs into this, this also solves the following error:

Error: Cannot find module '@babel/core'

When trying to use @svgr/webpack webpack plugin with Next 12.0.10.

Thanks for the Fix!! :D

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants