Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint link-passhref rule #33857

Merged
merged 2 commits into from Feb 1, 2022
Merged

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Feb 1, 2022

Bug

  • Related issues linked using fixes #33856
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #33856

ijjk
ijjk approved these changes Feb 1, 2022
Copy link
Member

@ijjk ijjk left a comment

Change and added test look good, thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Feb 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
buildDuration 16.6s 16.4s -163ms
buildDurationCached 4s 4.2s ⚠️ +151ms
nodeModulesSize 359 MB 359 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
/ failed reqs 0 0
/ total time (seconds) 3.885 3.862 -0.02
/ avg req/sec 643.46 647.39 +3.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.99 2.042 ⚠️ +0.05
/error-in-render avg req/sec 1256.03 1224.36 ⚠️ -31.67
Client Bundles (main, webpack, commons)
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
buildDuration 19.4s 20.9s ⚠️ +1.5s
buildDurationCached 4.1s 3.7s -346ms
nodeModulesSize 359 MB 359 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
/ failed reqs 0 0
/ total time (seconds) 3.768 4.025 ⚠️ +0.26
/ avg req/sec 663.48 621.17 ⚠️ -42.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.118 2.326 ⚠️ +0.21
/error-in-render avg req/sec 1180.25 1074.88 ⚠️ -105.37
Client Bundles (main, webpack, commons)
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary mutebg/next.js fix-eslint-link-passhref Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 97fded0

@ijjk ijjk merged commit a7793c7 into vercel:canary Feb 1, 2022
40 of 43 checks passed
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint rule link-passhref does not work
2 participants