Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image cache race condition #33883

Merged
merged 5 commits into from Feb 2, 2022
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Feb 1, 2022

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 1, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as ready for review Feb 2, 2022
@styfle styfle requested review from ijjk, shuding and timneutkens as code owners Feb 2, 2022
ijjk
ijjk approved these changes Feb 2, 2022
@ijjk
Copy link
Member

ijjk commented Feb 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
buildDuration 15.5s 15.2s -303ms
buildDurationCached 3.9s 3.8s -73ms
nodeModulesSize 359 MB 359 MB ⚠️ +451 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
/ failed reqs 0 0
/ total time (seconds) 3.518 3.573 ⚠️ +0.06
/ avg req/sec 710.53 699.75 ⚠️ -10.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.722 1.661 -0.06
/error-in-render avg req/sec 1452.01 1505.18 +53.17
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
buildDuration 18.8s 18.6s -210ms
buildDurationCached 3.8s 3.7s -104ms
nodeModulesSize 359 MB 359 MB ⚠️ +451 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
/ failed reqs 0 0
/ total time (seconds) 3.54 3.481 -0.06
/ avg req/sec 706.15 718.21 +12.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.624 1.571 -0.05
/error-in-render avg req/sec 1539.77 1591.06 +51.29
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.4 kB 71.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-image-cache-race-condition Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 552fa7f

@kodiakhq kodiakhq bot merged commit e3e62aa into canary Feb 2, 2022
40 of 42 checks passed
@kodiakhq kodiakhq bot deleted the fix-image-cache-race-condition branch Feb 2, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ENOENT: no such file or directory" - next.js crashes, related to image caching?
2 participants