Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure browserslist extends works properly #33890

Merged
merged 4 commits into from Feb 2, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 2, 2022

This ensures the compiled browserslist module handles extends config correctly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #33325

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 2, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Feb 2, 2022
@ijjk ijjk requested review from huozhi, shuding and timneutkens as code owners Feb 2, 2022
@ijjk ijjk requested review from balazsorban44 and styfle Feb 2, 2022
nodeFile,
content.replace(
/require\(require\.resolve\(/g,
`__non_webpack_require__(__non_webpack_require__.resolve(`
Copy link
Member

@huozhi huozhi Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add some comments for why replacing this?

Copy link
Member Author

@ijjk ijjk Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in cbdb13b

@ijjk ijjk requested a review from huozhi Feb 2, 2022
huozhi
huozhi approved these changes Feb 2, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
buildDuration 12.6s 12.6s ⚠️ +13ms
buildDurationCached 3.2s 3.3s ⚠️ +18ms
nodeModulesSize 359 MB 359 MB ⚠️ +726 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.96 2.968 ⚠️ +0.01
/ avg req/sec 844.48 842.45 ⚠️ -2.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.444 1.449 ⚠️ +0.01
/error-in-render avg req/sec 1731.08 1725.87 ⚠️ -5.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
index.html gzip 529 B 529 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
buildDuration 16.3s 16.6s ⚠️ +251ms
buildDurationCached 3.3s 3.2s -45ms
nodeModulesSize 359 MB 359 MB ⚠️ +726 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.968 2.998 ⚠️ +0.03
/ avg req/sec 842.43 833.98 ⚠️ -8.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.434 1.417 -0.02
/error-in-render avg req/sec 1743.85 1763.74 +19.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/browserslist-extends Change
index.html gzip 530 B 530 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB
Commit: cbdb13b

@ijjk ijjk merged commit cdc4ee3 into vercel:canary Feb 2, 2022
39 of 42 checks passed
@ijjk ijjk deleted the fix/browserslist-extends branch Feb 2, 2022
export default function Page() {
return <p className={styles.hello}>hello world</p>
}
`,
Copy link
Member

@styfle styfle Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything specifix to this code that browser list is interacting with? Or is it more of a hello world?

Copy link
Member Author

@ijjk ijjk Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just a hello world, it failed from just reading the browserslist config in package.json before this fix.

natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* Ensure browserslist extends works properly

* add comment
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browserslist error(module not found) when run next build
3 participants