Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing params for i18n optional route in minimal mode #33896

Merged
merged 2 commits into from Feb 2, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 2, 2022

This fixes our parsing of params with i18n for optional catch-all routes and ensures a regression test catches this case.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #30631

@ijjk ijjk added created-by: Next.js team type: next labels Feb 2, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Feb 2, 2022
@ijjk ijjk requested a review from styfle Feb 2, 2022
huozhi
huozhi approved these changes Feb 2, 2022
@ijjk
Copy link
Member Author

@ijjk ijjk commented Feb 2, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
buildDuration 12.1s 11.9s -154ms
buildDurationCached 3.1s 3.1s -9ms
nodeModulesSize 359 MB 359 MB ⚠️ +586 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
/ failed reqs 0 0
/ total time (seconds) 2.7 2.74 ⚠️ +0.04
/ avg req/sec 926.07 912.44 ⚠️ -13.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.183 1.175 -0.01
/error-in-render avg req/sec 2113.3 2127.29 +13.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
buildDuration 15.6s 15.5s -103ms
buildDurationCached 3s 3.1s ⚠️ +21ms
nodeModulesSize 359 MB 359 MB ⚠️ +586 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
/ failed reqs 0 0
/ total time (seconds) 2.746 2.791 ⚠️ +0.04
/ avg req/sec 910.28 895.7 ⚠️ -14.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.163 1.17 ⚠️ +0.01
/error-in-render avg req/sec 2149.84 2137.43 ⚠️ -12.41
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.4 kB 71.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-optional-route-case Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 12830f9

@kodiakhq kodiakhq bot merged commit f841307 into vercel:canary Feb 2, 2022
40 of 42 checks passed
@ijjk ijjk deleted the fix/i18n-optional-route-case branch Feb 2, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
)

This fixes our parsing of params with i18n for optional catch-all routes and ensures a regression test catches this case.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: vercel#30631
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants