Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Relay projects without artifactDirectory #33918

Merged
merged 9 commits into from Feb 2, 2022

Conversation

alunyov
Copy link
Contributor

@alunyov alunyov commented Feb 2, 2022

For the context: #33702 (comment)

This PR adds support for Relay projects that don't use artifactDirectory in their config.

  • If the JS with GraphQL text is located in pages, the plugin with throw the error.
  • If the JS file is outside of the pages - the plugin will require the generated artifact from __generated__ directory, next to the source file.

Test Plan:

  • Manually tested for the first case: Screen Shot 2022-02-02 at 10 14 51 AM

  • Updated the integration test

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

ijjk
ijjk approved these changes Feb 2, 2022
Copy link
Member

@ijjk ijjk left a comment

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Feb 2, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary alunyov/next.js relay-updates Change
buildDuration 12.8s 12.9s ⚠️ +141ms
buildDurationCached 3.3s 3.3s ⚠️ +24ms
nodeModulesSize 359 MB 359 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary alunyov/next.js relay-updates Change
/ failed reqs 0 0
/ total time (seconds) 3.024 3.01 -0.01
/ avg req/sec 826.73 830.49 +3.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.404 1.42 ⚠️ +0.02
/error-in-render avg req/sec 1781.13 1760.2 ⚠️ -20.93
Client Bundles (main, webpack, commons)
vercel/next.js canary alunyov/next.js relay-updates Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary alunyov/next.js relay-updates Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary alunyov/next.js relay-updates Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary alunyov/next.js relay-updates Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary alunyov/next.js relay-updates Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary alunyov/next.js relay-updates Change
buildDuration 16.2s 16.4s ⚠️ +126ms
buildDurationCached 3.3s 3.4s ⚠️ +107ms
nodeModulesSize 359 MB 359 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary alunyov/next.js relay-updates Change
/ failed reqs 0 0
/ total time (seconds) 3.032 3.069 ⚠️ +0.04
/ avg req/sec 824.51 814.51 ⚠️ -10
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.417 1.445 ⚠️ +0.03
/error-in-render avg req/sec 1764.31 1730.34 ⚠️ -33.97
Client Bundles (main, webpack, commons)
vercel/next.js canary alunyov/next.js relay-updates Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.4 kB 71.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary alunyov/next.js relay-updates Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary alunyov/next.js relay-updates Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.98 kB 4.98 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary alunyov/next.js relay-updates Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary alunyov/next.js relay-updates Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: ae59954

@ijjk ijjk merged commit 831d45d into vercel:canary Feb 2, 2022
39 of 42 checks passed
@alunyov alunyov deleted the relay-updates branch Feb 2, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
)

* update plugin

* Update the test

* remove dbg

* Use pages_dir in Relay

* copy edits

* cargo test

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants