Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect per page runtime config for functions manifest #33945

Merged
merged 12 commits into from Feb 6, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 3, 2022

Feature

Follow up for #33770

  • When page config specify runtime is "nodejs", remove runtime option in functions manifest;
  • If user enable concurrentFeatures and filesystem api, use runtime: "web" for those pages;
  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added

@ijjk ijjk added created-by: Next.js team type: next labels Feb 3, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as outdated.

@huozhi huozhi force-pushed the plugin/page-type-runtime branch from b8b4c7c to ca49e92 Compare Feb 3, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review Feb 3, 2022
@huozhi huozhi requested review from sokra and javivelasco Feb 3, 2022
expect(pages[path].runtime).toBe('web')
expect(pages[path].files.every((f) => f.startsWith('server/'))).toBe(true)
// Runtime of page `/` is undefined since it's configured as nodejs.
expect(runtime).toBe(path === '/' ? undefined : 'web')
Copy link
Member

@ijjk ijjk Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write the nodejs value to the manifest to be explicit and ensure the runtime field is always set?

Copy link
Member Author

@huozhi huozhi Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filesystem api currently use nodejs version, if leave empty it will use the project confiugured node version. I guess we can't leave it as "nodejs"

Copy link
Member

@javivelasco javivelasco Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely agree on having it always filled up

@ijjk

This comment has been minimized.

@anthonysidesap

This comment was marked as spam.

@ijjk

This comment has been minimized.

javivelasco
javivelasco previously approved these changes Feb 4, 2022
Copy link
Member

@javivelasco javivelasco left a comment

Looks awesome!

expect(pages[path].runtime).toBe('web')
expect(pages[path].files.every((f) => f.startsWith('server/'))).toBe(true)
// Runtime of page `/` is undefined since it's configured as nodejs.
expect(runtime).toBe(path === '/' ? undefined : 'web')
Copy link
Member

@javivelasco javivelasco Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely agree on having it always filled up

@ijjk

This comment has been minimized.

shuding
shuding approved these changes Feb 6, 2022
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
buildDuration 15.7s 15.7s -53ms
buildDurationCached 6.1s 6.1s ⚠️ +42ms
nodeModulesSize 359 MB 359 MB ⚠️ +8.47 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
/ failed reqs 0 0
/ total time (seconds) 3.25 3.221 -0.03
/ avg req/sec 769.29 776.11 +6.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.345 -0.03
/error-in-render avg req/sec 1819.52 1859.17 +39.65
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
buildDuration 19.2s 19.4s ⚠️ +212ms
buildDurationCached 6.1s 6.1s ⚠️ +41ms
nodeModulesSize 359 MB 359 MB ⚠️ +8.47 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
/ failed reqs 0 0
/ total time (seconds) 3.269 3.235 -0.03
/ avg req/sec 764.87 772.73 +7.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.375 1.389 ⚠️ +0.01
/error-in-render avg req/sec 1818.42 1800.09 ⚠️ -18.33
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js plugin/page-type-runtime Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: a2a738b

@kodiakhq kodiakhq bot merged commit c8fd6d8 into vercel:canary Feb 6, 2022
42 checks passed
@huozhi huozhi deleted the plugin/page-type-runtime branch Feb 7, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
## Feature

Follow up for vercel#33770

* When page config specify runtime is "nodejs", remove runtime option in functions manifest;
* If user enable `concurrentFeatures` and filesystem api, use `runtime: "web"` for those pages;


- [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants