Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-matching API routes can be rewritten #33966

Merged
merged 8 commits into from
Mar 1, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 4, 2022

This ensures non-matching API routes can be rewritten with i18n configured as currently we bail and render the 404 page when a locale prefixed API route is requested.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: slack thread
closes: #28921

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 4, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review March 1, 2022 18:14
@ijjk ijjk requested a review from styfle March 1, 2022 18:14
@ijjk

This comment has been minimized.

@ijjk ijjk requested a review from styfle March 1, 2022 20:02
@ijjk
Copy link
Member Author

ijjk commented Mar 1, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
buildDuration 20s 20.4s ⚠️ +396ms
buildDurationCached 7.7s 7.6s -91ms
nodeModulesSize 372 MB 372 MB ⚠️ +212 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 4.21 4.23 ⚠️ +0.02
/ avg req/sec 593.8 590.96 ⚠️ -2.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.189 2.078 -0.11
/error-in-render avg req/sec 1142.03 1203.32 +61.29
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
buildDuration 24.1s 23.7s -400ms
buildDurationCached 7.6s 7.7s ⚠️ +107ms
nodeModulesSize 372 MB 372 MB ⚠️ +212 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 4.247 4.197 -0.05
/ avg req/sec 588.59 595.66 +7.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.054 2.064 ⚠️ +0.01
/error-in-render avg req/sec 1217.32 1211.12 ⚠️ -6.2
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/allow-fallback-api-rewrite Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: bdfe2cb

@styfle styfle merged commit b6b5250 into vercel:canary Mar 1, 2022
@ijjk ijjk deleted the update/allow-fallback-api-rewrite branch March 1, 2022 21:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrites with i18n
2 participants