Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure optional chaining in swc matches babel #33995

Merged
merged 2 commits into from Feb 4, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 4, 2022

This ensures we always transpile optional chaining and nullish coalescing with swc the same as we do with babel since it can cause issues with webpack even when the node target supports these features.

The specific case this seems to cause issues with webpack is when a value is imported and optional chaining is used on the import value webpack is stripping the optional chaining cc @sokra

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #33915

@ijjk ijjk added created-by: Next.js team type: next labels Feb 4, 2022
@ijjk ijjk marked this pull request as ready for review Feb 4, 2022
@ijjk ijjk requested a review from kdy1 Feb 4, 2022
padmaia
padmaia approved these changes Feb 4, 2022
huozhi
huozhi approved these changes Feb 4, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 4, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
buildDuration 21.1s 20.6s -518ms
buildDurationCached 7.9s 7.9s -42ms
nodeModulesSize 359 MB 359 MB ⚠️ +941 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.164 4.048 -0.12
/ avg req/sec 600.32 617.52 +17.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.428 2.289 -0.14
/error-in-render avg req/sec 1029.83 1092.1 +62.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
buildDuration 25.7s 25.7s ⚠️ +33ms
buildDurationCached 7.8s 7.9s ⚠️ +56ms
nodeModulesSize 359 MB 359 MB ⚠️ +941 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.096 4.083 -0.01
/ avg req/sec 610.4 612.25 +1.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.218 2.302 ⚠️ +0.08
/error-in-render avg req/sec 1127.19 1085.8 ⚠️ -41.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/import-optional-chaining-swc Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: f9dbe2d

@kodiakhq kodiakhq bot merged commit a65e361 into vercel:canary Feb 4, 2022
40 of 42 checks passed
@ijjk ijjk deleted the fix/import-optional-chaining-swc branch Feb 4, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
This ensures we always transpile optional chaining and nullish coalescing with swc the same as we do [with babel](https://github.com/vercel/next.js/blob/4812e229928dc01ae21ee0533685f6813694c136/packages/next/build/babel/preset.ts#L97-L98) since it can cause issues with webpack even when the node target supports these features. 

The specific case this seems to cause issues with webpack is when a value is imported and optional chaining is used on the import value webpack is stripping the optional chaining cc @sokra 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: vercel#33915
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants