Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReadableStream in RenderResult #34005

Merged
merged 4 commits into from Feb 5, 2022

Conversation

devknoll
Copy link
Collaborator

@devknoll devknoll commented Feb 4, 2022

Since we're always using ReadableStream, we should just get rid of ResultPiper.

This also lets us replace things like bufferedReadFromReadableStream with a TransformStream that does the same thing, so that it's TransformStreams all the way down.

Finally, we can get rid of the one-off call to renderToReadableStream and just use renderToStream whenever we're rendering a concurrent tree.

@ijjk ijjk added created-by: Chrome Aurora type: next labels Feb 4, 2022
@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@devknoll devknoll marked this pull request as ready for review Feb 5, 2022
@ijjk
Copy link
Member

ijjk commented Feb 5, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
buildDuration 15.1s 15.1s ⚠️ +10ms
buildDurationCached 6s 6s -8ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.91 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
/ failed reqs 0 0
/ total time (seconds) 2.5 3.025 ⚠️ +0.52
/ avg req/sec 1000.15 826.32 ⚠️ -173.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.16 1.178 ⚠️ +0.02
/error-in-render avg req/sec 2154.66 2121.57 ⚠️ -33.09
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
buildDuration 18.5s 18.6s ⚠️ +153ms
buildDurationCached 6s 5.9s -65ms
nodeModulesSize 359 MB 359 MB ⚠️ +3.91 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
/ failed reqs 0 0
/ total time (seconds) 2.513 3.024 ⚠️ +0.51
/ avg req/sec 994.78 826.72 ⚠️ -168.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.158 -0.02
/error-in-render avg req/sec 2128.45 2158.79 +30.34
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-use-readable-streams Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: f159456

ijjk
ijjk approved these changes Feb 5, 2022
@kodiakhq kodiakhq bot merged commit 7e0b8aa into vercel:canary Feb 5, 2022
44 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
Since we're always using `ReadableStream`, we should just get rid of `ResultPiper`.

This also lets us replace things like `bufferedReadFromReadableStream` with a `TransformStream` that does the same thing, so that it's `TransformStream`s all the way down.

Finally, we can get rid of the one-off call to `renderToReadableStream` and just use `renderToStream` whenever we're rendering a concurrent tree.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants