Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn when application/ld+json scripts are used with next/head #34021

Merged
merged 2 commits into from Feb 5, 2022

Conversation

kara
Copy link
Collaborator

@kara kara commented Feb 5, 2022

In #33968, a warning was added for script tags inserted through the
next/head component. This change unintentionally included
application/ld+json scripts, which shouldn't be triggering the
warnings (as they were originally intended to catch scripts where
loading order or timing could be important). This change adds an
exception for application/ld+json scripts, so they do not log the
warning if they are included through next/head.

Bug

  • Related issues linked using fixes #number --no related issue, but addresses this comment
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

In vercel#33968, a warning was added for script tags inserted through the
next/head component. This change unintentionally included
application/ld+json scripts, which shouldn't be triggering the
warnings (as they were originally intended to catch scripts where
loading order or timing could be important). This change adds an
exception for application/ld+json scripts, so they do not log the
warning if they are included through next/head.
@ijjk ijjk added created-by: Chrome Aurora type: next labels Feb 5, 2022
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 5, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kara/next.js json Change
buildDuration 18.5s 17.7s -755ms
buildDurationCached 7s 7s -17ms
nodeModulesSize 359 MB 359 MB ⚠️ +182 B
Page Load Tests Overall increase ✓
vercel/next.js canary kara/next.js json Change
/ failed reqs 0 0
/ total time (seconds) 3.674 3.723 ⚠️ +0.05
/ avg req/sec 680.5 671.47 ⚠️ -9.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.63 1.558 -0.07
/error-in-render avg req/sec 1533.55 1604.73 +71.18
Client Bundles (main, webpack, commons)
vercel/next.js canary kara/next.js json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kara/next.js json Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kara/next.js json Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary kara/next.js json Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kara/next.js json Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kara/next.js json Change
buildDuration 21.4s 21.6s ⚠️ +194ms
buildDurationCached 6.9s 6.9s ⚠️ +9ms
nodeModulesSize 359 MB 359 MB ⚠️ +182 B
Page Load Tests Overall increase ✓
vercel/next.js canary kara/next.js json Change
/ failed reqs 0 0
/ total time (seconds) 3.703 3.66 -0.04
/ avg req/sec 675.04 683.09 +8.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.566 1.52 -0.05
/error-in-render avg req/sec 1596.9 1644.37 +47.47
Client Bundles (main, webpack, commons)
vercel/next.js canary kara/next.js json Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kara/next.js json Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kara/next.js json Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary kara/next.js json Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kara/next.js json Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 9c0e4fc

ijjk
ijjk approved these changes Feb 5, 2022
@ijjk ijjk merged commit d7de7de into vercel:canary Feb 5, 2022
38 of 41 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
…ercel#34021)

In vercel#33968, a warning was added for script tags inserted through the
next/head component. This change unintentionally included
application/ld+json scripts, which shouldn't be triggering the
warnings (as they were originally intended to catch scripts where
loading order or timing could be important). This change adds an
exception for application/ld+json scripts, so they do not log the
warning if they are included through next/head.
kodiakhq bot pushed a commit that referenced this issue Feb 28, 2022
x-ref: #34021 , #34004

Only log each warning once and only trigger in concurrent mode


## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants