Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data url handling in css-loader #34034

Merged
merged 3 commits into from Feb 6, 2022
Merged

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Feb 6, 2022

fixes #33920, backport from css-loader

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 6, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary alexander-akait/next.js fix-data-url Change
buildDuration 15.9s 15.8s -144ms
buildDurationCached 6.1s 6.1s ⚠️ +10ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary alexander-akait/next.js fix-data-url Change
/ failed reqs 0 0
/ total time (seconds) 3.263 3.281 ⚠️ +0.02
/ avg req/sec 766.15 762.02 ⚠️ -4.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.384 1.403 ⚠️ +0.02
/error-in-render avg req/sec 1806.74 1781.7 ⚠️ -25.04
Client Bundles (main, webpack, commons)
vercel/next.js canary alexander-akait/next.js fix-data-url Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary alexander-akait/next.js fix-data-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary alexander-akait/next.js fix-data-url Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary alexander-akait/next.js fix-data-url Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary alexander-akait/next.js fix-data-url Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary alexander-akait/next.js fix-data-url Change
buildDuration 19.4s 19.4s ⚠️ +49ms
buildDurationCached 6.1s 6.1s -35ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary alexander-akait/next.js fix-data-url Change
/ failed reqs 0 0
/ total time (seconds) 3.256 3.272 ⚠️ +0.02
/ avg req/sec 767.89 763.96 ⚠️ -3.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.391 1.383 -0.01
/error-in-render avg req/sec 1797.79 1807.3 +9.51
Client Bundles (main, webpack, commons)
vercel/next.js canary alexander-akait/next.js fix-data-url Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary alexander-akait/next.js fix-data-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary alexander-akait/next.js fix-data-url Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary alexander-akait/next.js fix-data-url Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary alexander-akait/next.js fix-data-url Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 2e9ec68

ijjk
ijjk approved these changes Feb 6, 2022
Copy link
Member

@ijjk ijjk left a comment

Looks good, thanks!

@ijjk ijjk changed the title fix: data url fix: data url handling in css-loader Feb 6, 2022
@ijjk ijjk merged commit 65e951e into vercel:canary Feb 6, 2022
8 of 10 checks passed
@alexander-akait alexander-akait deleted the fix-data-url branch Feb 6, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URIError: URI malformed at decodeURIComponent
2 participants