Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SWC minify from beta to release candidate #34056

Merged
merged 2 commits into from Feb 7, 2022

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 7, 2022

Given we've spent a ton of time testing and fixing minifier bugs the majority of cases should now be covered.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@timneutkens timneutkens requested review from ijjk, shuding and styfle as code owners Feb 7, 2022
@ijjk ijjk added created-by: Next.js team type: next labels Feb 7, 2022
@ijjk

This comment has been minimized.

styfle
styfle approved these changes Feb 7, 2022
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 7, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
buildDuration 18.9s 19s ⚠️ +126ms
buildDurationCached 7.3s 7.2s -95ms
nodeModulesSize 359 MB 359 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.812 -0.03
/ avg req/sec 650.83 655.9 +5.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.683 1.632 -0.05
/error-in-render avg req/sec 1485.19 1531.87 +46.68
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
buildDuration 22.1s 22.3s ⚠️ +228ms
buildDurationCached 7.3s 7s -318ms
nodeModulesSize 359 MB 359 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.78 -0.06
/ avg req/sec 650.93 661.43 +10.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.636 1.649 ⚠️ +0.01
/error-in-render avg req/sec 1527.8 1516.28 ⚠️ -11.52
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/release-candidate-swcminify Change
index.html gzip 534 B 534 B
link.html gzip 548 B 548 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: d6b1712

@kodiakhq kodiakhq bot merged commit 3be21c4 into vercel:canary Feb 7, 2022
42 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
Given we've spent a ton of time testing and fixing minifier bugs the majority of cases should now be covered.



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants