Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api-utils helper for testing #34078

Merged
merged 1 commit into from Feb 8, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 8, 2022

Adds a helper to api-utils for testing

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 8, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 8, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
buildDuration 15.6s 15.4s -115ms
buildDurationCached 6s 6s ⚠️ +26ms
nodeModulesSize 359 MB 359 MB ⚠️ +4.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
/ failed reqs 0 0
/ total time (seconds) 3.202 3.209 ⚠️ +0.01
/ avg req/sec 780.74 779.03 ⚠️ -1.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.333 1.357 ⚠️ +0.02
/error-in-render avg req/sec 1875.76 1842.18 ⚠️ -33.58
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
buildDuration 19.1s 19.1s -14ms
buildDurationCached 6.1s 6s -65ms
nodeModulesSize 359 MB 359 MB ⚠️ +4.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
/ failed reqs 0 0
/ total time (seconds) 3.242 3.214 -0.03
/ avg req/sec 771.18 777.82 +6.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.379 1.365 -0.01
/error-in-render avg req/sec 1813.27 1832.05 +18.78
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js feat/ondemand-revalidate Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 8cb50b3

@ijjk ijjk marked this pull request as ready for review Feb 8, 2022
@ijjk ijjk requested a review from Timer Feb 8, 2022
Timer
Timer approved these changes Feb 8, 2022
Copy link
Member

@Timer Timer left a comment

Great work. We can land and test since it's unstable_!

@ijjk ijjk merged commit 7cd9de3 into vercel:canary Feb 8, 2022
42 checks passed
@ijjk ijjk deleted the feat/ondemand-revalidate branch Feb 8, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants