Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix process polyfill on middleware #34426

Merged
merged 7 commits into from
Feb 18, 2022

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Feb 16, 2022

Fixes the problem that global process variable has only the env field.
Also fixed the issue that the env field is empty when the process module is used as the value of the variable (which happens when the module is contained in a dependency of application).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 17, 2022

Failing test suites

Commit: f34eaef

yarn testheadless test/integration/async-modules/test/index.test.js

  • Async modules > production mode > can render async AMP pages
  • Async modules > serverless mode > can render async AMP pages
Expand output

● Async modules › production mode › can render async AMP pages

TIMED OUT: just now

10 seconds ago

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

● Async modules › serverless mode › can render async AMP pages

TIMED OUT: just now

12 seconds ago

  474 |
  475 |   if (hardError) {
> 476 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  477 |   }
  478 |   return false
  479 | }

  at Object.check (lib/next-test-utils.js:476:11)
  at Object.<anonymous> (integration/async-modules/test/index.test.js:85:7)

Read more about building and testing Next.js in contributing.md.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
buildDuration 19.8s 18.5s -1.3s
buildDurationCached 7.5s 6.9s -565ms
nodeModulesSize 359 MB 359 MB ⚠️ +711 B
Page Load Tests Overall increase ✓
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
/ failed reqs 0 0
/ total time (seconds) 4.103 3.769 -0.33
/ avg req/sec 609.24 663.29 +54.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.011 2.021 ⚠️ +0.01
/error-in-render avg req/sec 1243.36 1236.87 ⚠️ -6.49
Client Bundles (main, webpack, commons)
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
buildDuration 22.1s 22.2s ⚠️ +105ms
buildDurationCached 6.9s 7.3s ⚠️ +351ms
nodeModulesSize 359 MB 359 MB ⚠️ +711 B
Page Load Tests Overall increase ✓
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
/ failed reqs 0 0
/ total time (seconds) 3.741 3.733 -0.01
/ avg req/sec 668.19 669.71 +1.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.932 1.901 -0.03
/error-in-render avg req/sec 1293.73 1314.93 +21.2
Client Bundles (main, webpack, commons)
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary nkzawa/next.js fix-middleware-process-polyfill Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: fcba5b0

@kodiakhq kodiakhq bot merged commit 7c103fa into vercel:canary Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
@nkzawa nkzawa deleted the fix-middleware-process-polyfill branch April 22, 2022 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants