Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't wrap profile in firebase example #34457

Merged
merged 1 commit into from Feb 17, 2022
Merged

fix: don't wrap profile in firebase example #34457

merged 1 commit into from Feb 17, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 17, 2022

Previous PR made this unnecessary change: https://github.com/vercel/next.js/pull/29581/files#diff-91aef2a7b24c67f77e8915e05ec22cdd71398650236a08e44420a1555367e99fL23-R25

Fixes #34077

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the area: examples Anything inside the examples folder label Feb 17, 2022
@balazsorban44 balazsorban44 merged commit ba78437 into canary Feb 17, 2022
7 checks passed
@balazsorban44 balazsorban44 deleted the fix/34077 branch Feb 17, 2022
This was referenced Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: examples Anything inside the examples folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js w/ Firebase Server-Side bug - simple fix
2 participants