Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation for relative URL usage in middlewares #34461

Merged

Conversation

Schniz
Copy link
Contributor

@Schniz Schniz commented Feb 17, 2022

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

huozhi
huozhi approved these changes Feb 17, 2022
@ijjk
Copy link
Member

ijjk commented Feb 17, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
buildDuration 18.9s 18.5s -480ms
buildDurationCached 7.2s 7.3s ⚠️ +162ms
nodeModulesSize 359 MB 359 MB -88 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
/ failed reqs 0 0
/ total time (seconds) 4.142 4.115 -0.03
/ avg req/sec 603.5 607.59 +4.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.941 1.989 ⚠️ +0.05
/error-in-render avg req/sec 1288.14 1256.97 ⚠️ -31.17
Client Bundles (main, webpack, commons)
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
buildDuration 22.7s 22.7s -23ms
buildDurationCached 7.1s 7.3s ⚠️ +203ms
nodeModulesSize 359 MB 359 MB -88 B
Page Load Tests Overall increase ✓
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
/ failed reqs 0 0
/ total time (seconds) 4.283 4.064 -0.22
/ avg req/sec 583.64 615.11 +31.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.014 2.051 ⚠️ +0.04
/error-in-render avg req/sec 1241.08 1219.01 ⚠️ -22.07
Client Bundles (main, webpack, commons)
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary Schniz/next.js remove-deprecation-for-relative-middleware-urls Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: f192a36

ijjk
ijjk approved these changes Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants