Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailingSlash in middleware SSR #34544

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 18, 2022

Bug

Fixes #34527

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as draft February 18, 2022 16:05
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review February 18, 2022 18:19
javivelasco
javivelasco previously approved these changes Feb 18, 2022
ijjk
ijjk previously approved these changes Feb 18, 2022
@huozhi huozhi dismissed stale reviews from ijjk and javivelasco via 462d867 February 18, 2022 21:11
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
buildDuration 21.6s 22.4s ⚠️ +706ms
buildDurationCached 8.3s 8.3s ⚠️ +71ms
nodeModulesSize 367 MB 367 MB ⚠️ +437 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 4.372 4.283 -0.09
/ avg req/sec 571.82 583.75 +11.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.204 2.254 ⚠️ +0.05
/error-in-render avg req/sec 1134.54 1109.1 ⚠️ -25.44
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
buildDuration 26.4s 26.6s ⚠️ +140ms
buildDurationCached 8.5s 8s -436ms
nodeModulesSize 367 MB 367 MB ⚠️ +437 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
/ failed reqs 0 0
/ total time (seconds) 4.721 4.473 -0.25
/ avg req/sec 529.56 558.94 +29.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.376 2.259 -0.12
/error-in-render avg req/sec 1052.19 1106.71 +54.52
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js streaming-path-rewrite Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: d87a7c8

@kodiakhq kodiakhq bot merged commit 6ed281d into vercel:canary Feb 18, 2022
@huozhi huozhi deleted the streaming-path-rewrite branch February 19, 2022 11:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling trailingSlash will hang the request in RSC
4 participants