Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next/image incorrectly warning for position: absolute parent #34551

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
buildDuration 15.8s 16.1s ⚠️ +259ms
buildDurationCached 6.2s 6.2s -41ms
nodeModulesSize 359 MB 359 MB ⚠️ +67 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
/ failed reqs 0 0
/ total time (seconds) 3.055 3.013 -0.04
/ avg req/sec 818.32 829.63 +11.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.402 1.369 -0.03
/error-in-render avg req/sec 1783.41 1826.47 +43.06
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
buildDuration 19.3s 19.4s ⚠️ +65ms
buildDurationCached 6.3s 6.1s -140ms
nodeModulesSize 359 MB 359 MB ⚠️ +67 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
/ failed reqs 0 0
/ total time (seconds) 3.029 3.022 -0.01
/ avg req/sec 825.32 827.32 +2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.39 ⚠️ +0.02
/error-in-render avg req/sec 1828.84 1798.17 ⚠️ -30.67
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-warning-layout-fill-absolute Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 58d2c46

@kodiakhq kodiakhq bot merged commit 9e77ef4 into canary Feb 18, 2022
@kodiakhq kodiakhq bot deleted the fix-warning-layout-fill-absolute branch February 18, 2022 18:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants