Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect telemetry for ESLint rules #34564

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

kyliau
Copy link

@kyliau kyliau commented Feb 18, 2022

This commit adds functionality to track usage of @next/next/* ESLint rules and their severity levels.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Feb 18, 2022
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kyliau/next.js next-rules-enabled Change
buildDuration 16s 16s ⚠️ +20ms
buildDurationCached 6.2s 6.2s -75ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.91 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kyliau/next.js next-rules-enabled Change
/ failed reqs 0 0
/ total time (seconds) 3.108 3.033 -0.08
/ avg req/sec 804.42 824.31 +19.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.417 1.42 0
/error-in-render avg req/sec 1763.71 1760.33 ⚠️ -3.38
Client Bundles (main, webpack)
vercel/next.js canary kyliau/next.js next-rules-enabled Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js next-rules-enabled Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kyliau/next.js next-rules-enabled Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kyliau/next.js next-rules-enabled Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kyliau/next.js next-rules-enabled Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kyliau/next.js next-rules-enabled Change
buildDuration 19.4s 19.5s ⚠️ +149ms
buildDurationCached 6.2s 6.1s -128ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.91 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kyliau/next.js next-rules-enabled Change
/ failed reqs 0 0
/ total time (seconds) 2.991 3.031 ⚠️ +0.04
/ avg req/sec 835.98 824.7 ⚠️ -11.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.424 1.42 0
/error-in-render avg req/sec 1755.31 1760.18 +4.87
Client Bundles (main, webpack)
vercel/next.js canary kyliau/next.js next-rules-enabled Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kyliau/next.js next-rules-enabled Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kyliau/next.js next-rules-enabled Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kyliau/next.js next-rules-enabled Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kyliau/next.js next-rules-enabled Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: fd0f270

@kodiakhq kodiakhq bot merged commit fbb8536 into vercel:canary Feb 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants