Fix react-dom type error in CNA typescript template

[eungyeole]

I imported react-dom to use createPortal, but found that there is no @types version.
So I added @types/react-dom to the devDependencies of the create-next-app typecript template.

Could this be a contribution?

[balazsorban44]

I think it's debatable if this should be added to the default template, as those react-dom APIs are less common. If needed, you can always install them manually.

[eungyeole]

@balazsorban44

I think it's debatable if this should be added to the default template, as those react-dom APIs are less common. If needed, you can always install them manually.

If I were to give my opinion, Next.js have react-dom as a dependancy in the typescript template, and it seems a bit strange that I have to separately install the @types version to use it.

[balazsorban44]

Looks good, thanks!

[balazsorban44]

Before merging, could you update this test suite

next.js/test/integration/create-next-app/index.test.js

Line 145 in ea532c7

'@types/react',

[eungyeole]

Before merging, could you update this test suite

next.js/test/integration/create-next-app/index.test.js

Line 146 in 53e3fe4

'@types/react-dom',

@balazsorban44 ,
Are you sure you're talking about this?
I don't know if it's right.

[balazsorban44]

My bad... 🤦 I overlooked that you already updated the test suite! All should be good now from me!

[eungyeole]

@balazsorban44
Thank you for your interest!
I think all the test suite worked well.!

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General

	vercel/next.js canary	eungyeole/next.js canary	Change
buildDuration	15.6s	15.7s	⚠️ +142ms
buildDurationCached	6.1s	6.2s	⚠️ +61ms
nodeModulesSize	367 MB	367 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	eungyeole/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.916	2.968	⚠️ +0.05
/ avg req/sec	857.27	842.31	⚠️ -14.96
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.355	1.387	⚠️ +0.03
/error-in-render avg req/sec	1845.24	1802.46	⚠️ -42.78

Client Bundles (main, webpack)

	vercel/next.js canary	eungyeole/next.js canary	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.8 kB	27.8 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.5 kB	71.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	eungyeole/next.js canary	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	eungyeole/next.js canary	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	eungyeole/next.js canary	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	eungyeole/next.js canary	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General

	vercel/next.js canary	eungyeole/next.js canary	Change
buildDuration	19.1s	19s	-138ms
buildDurationCached	6.1s	6.2s	⚠️ +77ms
nodeModulesSize	367 MB	367 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	eungyeole/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.982	2.977	-0.01
/ avg req/sec	838.24	839.83	+1.59
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.311	1.389	⚠️ +0.08
/error-in-render avg req/sec	1906.48	1800.2	⚠️ -106.28

Client Bundles (main, webpack)

	vercel/next.js canary	eungyeole/next.js canary	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.8 kB	27.8 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	eungyeole/next.js canary	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	eungyeole/next.js canary	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.08 kB	5.08 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	eungyeole/next.js canary	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	eungyeole/next.js canary	Change
index.html gzip	534 B	534 B	✓
link.html gzip	547 B	547 B	✓
withRouter.html gzip	527 B	527 B	✓
Overall change	1.61 kB	1.61 kB	✓

Commit: 1ee48e2