Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize image optimizer error status codes #34699

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 23, 2022

Updates to ensure we return an error status code when ImageError is used regardless of the upstream status.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 23, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 23, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
buildDuration 15.5s 15.3s -205ms
buildDurationCached 6s 6s ⚠️ +1ms
nodeModulesSize 367 MB 367 MB ⚠️ +275 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
/ failed reqs 0 0
/ total time (seconds) 2.785 2.792 ⚠️ +0.01
/ avg req/sec 897.6 895.3 ⚠️ -2.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.18 1.17 -0.01
/error-in-render avg req/sec 2118.22 2137.31 +19.09
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
buildDuration 18.6s 18.5s -157ms
buildDurationCached 6.1s 6.1s -68ms
nodeModulesSize 367 MB 367 MB ⚠️ +275 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
/ failed reqs 0 0
/ total time (seconds) 2.753 2.763 ⚠️ +0.01
/ avg req/sec 908.05 904.79 ⚠️ -3.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.172 1.155 -0.02
/error-in-render avg req/sec 2133.58 2163.71 +30.13
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/normalize-image-error-status Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: c6e8b98

@ijjk ijjk marked this pull request as ready for review February 23, 2022 00:32
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 99ee222 into vercel:canary Feb 23, 2022
@ijjk ijjk deleted the add/normalize-image-error-status branch February 23, 2022 01:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants