Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entries generation in hot-reloader #34733

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Feb 23, 2022

Refactored the code a bit in preparation for the per-page runtime config.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 23, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@shuding shuding marked this pull request as ready for review February 24, 2022 12:09
@ijjk
Copy link
Member

ijjk commented Feb 24, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/e898 Change
buildDuration 19.5s 19.9s ⚠️ +332ms
buildDurationCached 7.6s 7.7s ⚠️ +67ms
nodeModulesSize 367 MB 367 MB ⚠️ +631 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/e898 Change
/ failed reqs 0 0
/ total time (seconds) 3.699 3.771 ⚠️ +0.07
/ avg req/sec 675.89 662.96 ⚠️ -12.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.728 1.729 0
/error-in-render avg req/sec 1446.42 1445.62 ⚠️ -0.8
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/e898 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/e898 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/e898 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/e898 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/e898 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/e898 Change
buildDuration 24s 23.7s -322ms
buildDurationCached 7.7s 7.7s -22ms
nodeModulesSize 367 MB 367 MB ⚠️ +631 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/e898 Change
/ failed reqs 0 0
/ total time (seconds) 3.815 3.812 0
/ avg req/sec 655.37 655.87 +0.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.763 1.762 0
/error-in-render avg req/sec 1417.71 1418.64 +0.93
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/e898 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/e898 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/e898 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/e898 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/e898 Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: de2cf71

@ijjk ijjk merged commit ceecf91 into vercel:canary Feb 24, 2022
@shuding shuding deleted the shu/e898 branch February 25, 2022 15:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants