Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @napi-rs/triples to support android arm platform #34752

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

Brooooooklyn
Copy link
Contributor

Fix #33530

Android arm is supported in #34481, but @napi-rs/triples was forgotten to upgrade in the previous pull request.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 24, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
buildDuration 15.1s 15.4s ⚠️ +281ms
buildDurationCached 6s 6s -27ms
nodeModulesSize 367 MB 367 MB -1.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
/ failed reqs 0 0
/ total time (seconds) 2.759 2.758 0
/ avg req/sec 906.22 906.58 +0.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.163 1.165 0
/error-in-render avg req/sec 2150.17 2146.23 ⚠️ -3.94
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
buildDuration 18.5s 18.7s ⚠️ +180ms
buildDurationCached 6s 6s ⚠️ +38ms
nodeModulesSize 367 MB 367 MB -1.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
/ failed reqs 0 0
/ total time (seconds) 2.76 2.774 ⚠️ +0.01
/ avg req/sec 905.7 901.09 ⚠️ -4.61
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.164 1.163 0
/error-in-render avg req/sec 2147.42 2148.99 +1.57
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade-napi-triples Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 574317d

@kodiakhq kodiakhq bot merged commit 5d7c4dc into canary Feb 24, 2022
@kodiakhq kodiakhq bot deleted the upgrade-napi-triples branch February 24, 2022 10:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants