Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for Yarn PnP v3 with Node.js < 16.14 #34818

Merged
merged 5 commits into from
Feb 25, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 25, 2022

This ensures to warn when Yarn PnP is being used with a lower Node.js version as this can cause jest-worker to hang unexpectedly due to a bug in Node.js with ESM.

x-ref: #34794
x-ref: #34688
x-ref: #34799

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 25, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review February 25, 2022 19:02
@ijjk ijjk requested a review from styfle February 25, 2022 19:02
packages/next/bin/next.ts Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk requested a review from styfle February 25, 2022 19:06
packages/next/bin/next.ts Outdated Show resolved Hide resolved
Co-authored-by: Steven <steven@ceriously.com>
styfle
styfle previously approved these changes Feb 25, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 25, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
buildDuration 18.3s 18.1s -194ms
buildDurationCached 7s 6.9s -102ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.34 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.746 3.798 ⚠️ +0.05
/ avg req/sec 667.31 658.15 ⚠️ -9.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.913 1.939 ⚠️ +0.03
/error-in-render avg req/sec 1307.18 1289.51 ⚠️ -17.67
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
buildDuration 22.1s 22.1s ⚠️ +9ms
buildDurationCached 6.9s 7.2s ⚠️ +284ms
nodeModulesSize 367 MB 367 MB ⚠️ +1.34 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
/ failed reqs 0 0
/ total time (seconds) 3.689 3.701 ⚠️ +0.01
/ avg req/sec 677.69 675.52 ⚠️ -2.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.898 1.978 ⚠️ +0.08
/error-in-render avg req/sec 1316.95 1263.93 ⚠️ -53.02
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/pnp-node-warning Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: f614ab1

@ijjk ijjk merged commit d09fb1d into vercel:canary Feb 25, 2022
@ijjk ijjk deleted the add/pnp-node-warning branch February 25, 2022 19:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants