Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-react to latest version #34819

Merged
merged 4 commits into from
Feb 26, 2022
Merged

Update eslint-plugin-react to latest version #34819

merged 4 commits into from
Feb 26, 2022

Conversation

kolarski
Copy link
Contributor

@kolarski kolarski commented Feb 25, 2022

There is currently a bug in eslint-plugin-react jsx-eslint/eslint-plugin-react#3215.
The bug reports valid code as errors.
The bug was just fixed in 7.29.1

Closes: #34837

There is currently a bug in eslint-plugin-react jsx-eslint/eslint-plugin-react#3215.
The bug was just fixed in 7.29.1
@ijjk

This comment has been minimized.

# Conflicts:
#	packages/eslint-config-next/package.json
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 26, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kolarski/next.js patch-1 Change
buildDuration 15.1s 15s -114ms
buildDurationCached 6s 6s -10ms
nodeModulesSize 368 MB 368 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kolarski/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.753 2.76 ⚠️ +0.01
/ avg req/sec 907.99 905.94 ⚠️ -2.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.158 1.164 ⚠️ +0.01
/error-in-render avg req/sec 2159.02 2148.5 ⚠️ -10.52
Client Bundles (main, webpack)
vercel/next.js canary kolarski/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kolarski/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kolarski/next.js patch-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kolarski/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kolarski/next.js patch-1 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kolarski/next.js patch-1 Change
buildDuration 18.3s 18.4s ⚠️ +51ms
buildDurationCached 6s 6s ⚠️ +81ms
nodeModulesSize 368 MB 368 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kolarski/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.751 2.775 ⚠️ +0.02
/ avg req/sec 908.9 901.04 ⚠️ -7.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.155 1.173 ⚠️ +0.02
/error-in-render avg req/sec 2163.94 2130.48 ⚠️ -33.46
Client Bundles (main, webpack)
vercel/next.js canary kolarski/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kolarski/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kolarski/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kolarski/next.js patch-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kolarski/next.js patch-1 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 795eea7

@ijjk ijjk merged commit 89c9ce8 into vercel:canary Feb 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants