Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image optimization invalid internal upstream image #34899

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Feb 28, 2022

This gracefully handles errors when the url query string param looks like an internal image because it starts with / but it is not pointing to an internal image.

Previously, this was printing an unnecessary stack trace when the upstream content-type was undefined.

ijjk
ijjk previously approved these changes Feb 28, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 1, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
buildDuration 16.2s 16s -196ms
buildDurationCached 6.3s 6.3s -52ms
nodeModulesSize 368 MB 368 MB ⚠️ +490 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
/ failed reqs 0 0
/ total time (seconds) 3.123 3.194 ⚠️ +0.07
/ avg req/sec 800.61 782.71 ⚠️ -17.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.383 1.407 ⚠️ +0.02
/error-in-render avg req/sec 1808.25 1777.13 ⚠️ -31.12
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
buildDuration 19.7s 20.2s ⚠️ +497ms
buildDurationCached 6.4s 6.4s -41ms
nodeModulesSize 368 MB 368 MB ⚠️ +490 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
/ failed reqs 0 0
/ total time (seconds) 3.178 3.28 ⚠️ +0.1
/ avg req/sec 786.56 762.25 ⚠️ -24.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.408 1.451 ⚠️ +0.04
/error-in-render avg req/sec 1775.72 1723.41 ⚠️ -52.31
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-image-optimization-invalid-upstream Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 75d1215

@kodiakhq kodiakhq bot merged commit 0816b77 into canary Mar 1, 2022
@kodiakhq kodiakhq bot deleted the fix-image-optimization-invalid-upstream branch March 1, 2022 16:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants