Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next/image noscript when blur and priority #34973

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 2, 2022

Fixes a bug where browsers with scripts disabled did not work with <Image placeholder="blur" priority />.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 2, 2022
@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as ready for review March 2, 2022 19:38
@styfle styfle requested a review from atcastle March 2, 2022 19:44
@ijjk
Copy link
Member

ijjk commented Mar 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
buildDuration 15s 15.1s ⚠️ +143ms
buildDurationCached 6s 6s -1ms
nodeModulesSize 372 MB 372 MB ⚠️ +55 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
/ failed reqs 0 0
/ total time (seconds) 2.885 2.885
/ avg req/sec 866.43 866.41 ⚠️ -0.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.186 1.131 -0.05
/error-in-render avg req/sec 2108.65 2210.94 +102.29
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.05 kB 5.06 kB ⚠️ +6 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.8 kB ⚠️ +6 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
_buildManifest.js gzip 459 B 460 B ⚠️ +1 B
Overall change 459 B 460 B ⚠️ +1 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Diffs

Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-35c32b80abf212d2.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-8642d114a09c62c5.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-21c1812d1ebeffa4.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-e3445a41cd45d90f.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-0b3d72804dab6202.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-00527c3f2207a902.js"
Diff for image-HASH.js
@@ -786,7 +786,7 @@
               style: _objectSpread({}, imgStyle, blurStyle)
             })
           ),
-          isLazy &&
+          (isLazy || placeholder === "blur") &&
             /*#__PURE__*/ _react.default.createElement(
               "noscript",
               null,

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
buildDuration 18.2s 18.1s -125ms
buildDurationCached 6.1s 6s -76ms
nodeModulesSize 372 MB 372 MB ⚠️ +55 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
/ failed reqs 0 0
/ total time (seconds) 2.877 2.861 -0.02
/ avg req/sec 868.89 873.81 +4.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.141 -0.03
/error-in-render avg req/sec 2127.01 2191.43 +64.42
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB ⚠️ +4 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB ⚠️ +4 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
_buildManifest.js gzip 456 B 458 B ⚠️ +2 B
Overall change 456 B 458 B ⚠️ +2 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-placeholder-blur-with-priority Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Diffs

Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
   ],
   "/head": ["static\u002Fchunks\u002Fpages\u002Fhead-35c32b80abf212d2.js"],
   "/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-8642d114a09c62c5.js"],
-  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-21c1812d1ebeffa4.js"],
+  "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-e3445a41cd45d90f.js"],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-0b3d72804dab6202.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-00527c3f2207a902.js"
Diff for image-HASH.js
@@ -786,7 +786,7 @@
               style: _objectSpread({}, imgStyle, blurStyle)
             })
           ),
-          isLazy &&
+          (isLazy || placeholder === "blur") &&
             /*#__PURE__*/ _react.default.createElement(
               "noscript",
               null,
Commit: 1d56c8b

@kodiakhq kodiakhq bot merged commit 65e704d into canary Mar 2, 2022
@kodiakhq kodiakhq bot deleted the fix-placeholder-blur-with-priority branch March 2, 2022 19:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants