Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named export missing from client components #34974

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 2, 2022

Closes #33538.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

huozhi
huozhi previously approved these changes Mar 2, 2022
ijjk
ijjk previously approved these changes Mar 2, 2022
@shuding shuding dismissed stale reviews from ijjk and huozhi via 273ec4d March 2, 2022 20:37
@ijjk
Copy link
Member

ijjk commented Mar 2, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8af8 Change
buildDuration 17.5s 17.7s ⚠️ +168ms
buildDurationCached 6.7s 6.6s -55ms
nodeModulesSize 372 MB 372 MB ⚠️ +962 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/8af8 Change
/ failed reqs 0 0
/ total time (seconds) 3.804 3.73 -0.07
/ avg req/sec 657.22 670.23 +13.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.932 1.873 -0.06
/error-in-render avg req/sec 1294.06 1334.85 +40.79
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/8af8 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8af8 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8af8 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.06 kB 5.06 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8af8 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8af8 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8af8 Change
buildDuration 21.2s 21.7s ⚠️ +450ms
buildDurationCached 6.7s 6.8s ⚠️ +42ms
nodeModulesSize 372 MB 372 MB ⚠️ +962 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/8af8 Change
/ failed reqs 0 0
/ total time (seconds) 3.7 3.755 ⚠️ +0.05
/ avg req/sec 675.61 665.76 ⚠️ -9.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.778 1.878 ⚠️ +0.1
/error-in-render avg req/sec 1406.27 1331.31 ⚠️ -74.96
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/8af8 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8af8 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8af8 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.2 kB 5.2 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.9 kB 14.9 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8af8 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8af8 Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 273ec4d

@kodiakhq kodiakhq bot merged commit 1f16329 into vercel:canary Mar 2, 2022
@shuding shuding deleted the shu/8af8 branch March 3, 2022 06:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named exports of components are not supported
3 participants