Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Use more semantic footer element #35033

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

leyanlo
Copy link
Contributor

@leyanlo leyanlo commented Mar 3, 2022

Use more semantic footer element for example blog footer. Also remove unused styles. No visual changes.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Use more semantic footer element for example blog footer. Also remove unused styles. No visual changes.
@ijjk ijjk added the examples Issue/PR related to examples label Mar 3, 2022
leerob
leerob previously approved these changes Mar 3, 2022
ijjk
ijjk previously approved these changes Mar 3, 2022
@ijjk ijjk dismissed stale reviews from leerob and themself via 4d51027 March 8, 2022 18:36
@kodiakhq kodiakhq bot merged commit d3cd00c into vercel:canary Mar 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants