Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt react 18 rc2 #35161

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Adopt react 18 rc2 #35161

merged 4 commits into from
Mar 9, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 9, 2022

Bump react 18 to rc2 for according to the streaming API changes

x-ref: reactwg/react-18#127

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 9, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review March 9, 2022 13:37
@huozhi huozhi requested a review from styfle as a code owner March 9, 2022 15:11
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from shuding March 9, 2022 17:59
@ijjk

This comment was marked as outdated.

@ijjk
Copy link
Member

ijjk commented Mar 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js react-18-rc2 Change
buildDuration 19.3s 18.9s -393ms
buildDurationCached 7.3s 7.2s -128ms
nodeModulesSize 372 MB 372 MB -780 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js react-18-rc2 Change
/ failed reqs 0 0
/ total time (seconds) 4.065 4.018 -0.05
/ avg req/sec 615.03 622.22 +7.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.05 2.043 -0.01
/error-in-render avg req/sec 1219.32 1223.76 +4.44
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-18-rc2 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-18-rc2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-18-rc2 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-18-rc2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-18-rc2 Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js react-18-rc2 Change
buildDuration 23.1s 22.4s -769ms
buildDurationCached 7.6s 7.4s -263ms
nodeModulesSize 372 MB 372 MB -780 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js react-18-rc2 Change
/ failed reqs 0 0
/ total time (seconds) 4.079 4.087 ⚠️ +0.01
/ avg req/sec 612.88 611.71 ⚠️ -1.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.079 2.032 -0.05
/error-in-render avg req/sec 1202.6 1230.05 +27.45
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js react-18-rc2 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js react-18-rc2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js react-18-rc2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js react-18-rc2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js react-18-rc2 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 2a5a0b0

@huozhi huozhi merged commit 9bff48b into vercel:canary Mar 9, 2022
@huozhi huozhi deleted the react-18-rc2 branch March 9, 2022 20:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants