Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cssnano-simple #35258

Merged
merged 1 commit into from
Mar 11, 2022
Merged

chore: upgrade cssnano-simple #35258

merged 1 commit into from
Mar 11, 2022

Conversation

balazsorban44
Copy link
Member

Fixes #35219

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Mar 11, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
buildDuration 16.2s 15.8s -377ms
buildDurationCached 6.2s 6.3s ⚠️ +66ms
nodeModulesSize 378 MB 378 MB -31.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
/ failed reqs 0 0
/ total time (seconds) 3.189 3.169 -0.02
/ avg req/sec 783.95 788.87 +4.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.431 1.424 -0.01
/error-in-render avg req/sec 1746.89 1755.21 +8.32
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.09 kB 5.09 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.8 kB 14.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
buildDuration 19.5s 19.5s ⚠️ +9ms
buildDurationCached 6.4s 6.3s -92ms
nodeModulesSize 378 MB 378 MB -31.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
/ failed reqs 0 0
/ total time (seconds) 3.304 3.136 -0.17
/ avg req/sec 756.63 797.09 +40.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.458 1.408 -0.05
/error-in-render avg req/sec 1714.72 1775.33 +60.61
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.23 kB 5.23 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15 kB 15 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/update-cssnano-simple Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 4f1b871

@kodiakhq kodiakhq bot merged commit 9145565 into canary Mar 11, 2022
@kodiakhq kodiakhq bot deleted the fix/update-cssnano-simple branch March 11, 2022 16:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css border shorthand incorrectly minified in production
2 participants