Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on-demand ISR to skip fetch locally #35386

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 17, 2022

This updates on-demand ISR to skip the fetch step locally and instead revalidate directly through the internal server method to avoid conflicts from differing network setups which matches our handling for the image-optimizer. This also exposes the original error when we fail to revalidate to make it more clear what is causing the failure.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #35309

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 17, 2022
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review March 17, 2022 02:42
@ijjk ijjk requested a review from styfle March 17, 2022 02:43
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member Author

ijjk commented Mar 17, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
buildDuration 15.7s 15.8s ⚠️ +53ms
buildDurationCached 6.2s 6.1s -119ms
nodeModulesSize 456 MB 456 MB ⚠️ +2.39 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
/ failed reqs 0 0
/ total time (seconds) 3.164 3.163 0
/ avg req/sec 790.15 790.26 +0.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.364 1.363 0
/error-in-render avg req/sec 1832.23 1834.17 +1.94
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
buildDuration 19.1s 19.2s ⚠️ +155ms
buildDurationCached 6.1s 6.2s ⚠️ +74ms
nodeModulesSize 456 MB 456 MB ⚠️ +2.39 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
/ failed reqs 0 0
/ total time (seconds) 3.167 3.217 ⚠️ +0.05
/ avg req/sec 789.37 777.16 ⚠️ -12.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.399 1.405 ⚠️ +0.01
/error-in-render avg req/sec 1787.01 1779.26 ⚠️ -7.75
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/local-ondemand-revalidate Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 462758d

@ijjk ijjk merged commit d3a53a6 into vercel:canary Mar 17, 2022
@ijjk ijjk deleted the update/local-ondemand-revalidate branch March 17, 2022 17:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-demand ISR unable to revalidate page after build using Node 17
2 participants