Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't override user-agent in fetch if specified #35547

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Mar 23, 2022

Related

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Mar 28, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
buildDuration 15.3s 15.4s ⚠️ +100ms
buildDurationCached 6.1s 6.1s ⚠️ +4ms
nodeModulesSize 467 MB 467 MB ⚠️ +137 B
Page Load Tests Overall increase ✓
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
/ failed reqs 0 0
/ total time (seconds) 2.988 2.961 -0.03
/ avg req/sec 836.6 844.39 +7.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.225 1.204 -0.02
/error-in-render avg req/sec 2040 2076.55 +36.55
Client Bundles (main, webpack)
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
buildDuration 18.6s 18.7s ⚠️ +121ms
buildDurationCached 6.2s 6s -193ms
nodeModulesSize 467 MB 467 MB ⚠️ +137 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
/ failed reqs 0 0
/ total time (seconds) 2.964 2.946 -0.02
/ avg req/sec 843.43 848.64 +5.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.204 1.227 ⚠️ +0.02
/error-in-render avg req/sec 2076.58 2036.97 ⚠️ -39.61
Client Bundles (main, webpack)
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary SethFalco/next.js 35546-fetch-user-agent Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 9947abf

@ijjk ijjk merged commit ad7cb3b into vercel:canary Mar 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
@SethFalco SethFalco deleted the 35546-fetch-user-agent branch June 15, 2024 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't override user-agent in fetch API in Next.js middleware
2 participants