Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC: handle commonjs in flight loader #35563

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 24, 2022

We need to handle cjs cases for client/server components when they're compiled to commonjs in some cases.
e.g. if there's an internal _app.server.js in nextjs, the assets in the dist files are compiled to cjs by swc. Or any 3rd party libraries are consumed could be cjs only.

How it works

  • Detect the source file is ESM or CJS first by detect if there's any ESM import/export
  • Append the new exports or collect exports info based on the module type

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Mar 24, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review March 25, 2022 20:55
@ijjk
Copy link
Member

ijjk commented Mar 25, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
buildDuration 15.3s 15.7s ⚠️ +395ms
buildDurationCached 6.1s 6s -37ms
nodeModulesSize 467 MB 467 MB ⚠️ +3.33 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
/ failed reqs 0 0
/ total time (seconds) 2.898 2.948 ⚠️ +0.05
/ avg req/sec 862.6 847.94 ⚠️ -14.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.172 1.174 0
/error-in-render avg req/sec 2133.68 2129.81 ⚠️ -3.87
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
buildDuration 18.8s 18.9s ⚠️ +155ms
buildDurationCached 6.1s 6s -75ms
nodeModulesSize 467 MB 467 MB ⚠️ +3.33 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
/ failed reqs 0 0
/ total time (seconds) 2.949 2.93 -0.02
/ avg req/sec 847.66 853.32 +5.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.187 1.183 0
/error-in-render avg req/sec 2106.19 2113.39 +7.2
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/loader-cjs Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6c8e8ce

@kodiakhq kodiakhq bot merged commit 4e8e191 into vercel:canary Mar 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants