Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable script worker in edge and fix rsc loader and runtime #35604

Merged
merged 4 commits into from
Mar 26, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 26, 2022

  • Disable script worker for edge runtime (could lead to build error)
  • Fix rsc loader CJS detection
  • Fix pagePath searching for per-page runtime

test through rsc notes demo, successful deployment: https://next-rsc-notes-9bix7l1nu.vercel.sh/

@ijjk

This comment has been minimized.

const pagePath = pagePaths.find(
(p) =>
p.startsWith(actualPage + '.') ||
p.startsWith(actualPage + '/index.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the case of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder/index.server.js, like note/edit/index.server.js. The page is normalized so it doesn’t contain index

@huozhi huozhi requested a review from shuding March 26, 2022 01:32
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 26, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/edge-worker Change
buildDuration 15s 15.2s ⚠️ +148ms
buildDurationCached 6.1s 6s -34ms
nodeModulesSize 467 MB 467 MB ⚠️ +318 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/edge-worker Change
/ failed reqs 0 0
/ total time (seconds) 2.9 2.92 ⚠️ +0.02
/ avg req/sec 862.19 856.13 ⚠️ -6.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.152 1.157 ⚠️ +0.01
/error-in-render avg req/sec 2170.13 2161.41 ⚠️ -8.72
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/edge-worker Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/edge-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/edge-worker Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/edge-worker Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/edge-worker Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/edge-worker Change
buildDuration 18.5s 18.6s ⚠️ +57ms
buildDurationCached 5.9s 6s ⚠️ +55ms
nodeModulesSize 467 MB 467 MB ⚠️ +318 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/edge-worker Change
/ failed reqs 0 0
/ total time (seconds) 2.923 2.907 -0.02
/ avg req/sec 855.35 860.09 +4.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.175 1.171 0
/error-in-render avg req/sec 2127.95 2135.43 +7.48
Client Bundles (main, webpack)
vercel/next.js canary huozhi/next.js fix/edge-worker Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/edge-worker Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/edge-worker Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/edge-worker Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/edge-worker Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3575cb2

@kodiakhq kodiakhq bot merged commit b82f546 into vercel:canary Mar 26, 2022
@huozhi huozhi deleted the fix/edge-worker branch March 26, 2022 09:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants