Only resolve page runtime for react 18 and error on read failure

[huozhi]

• Read the proper page file from either pages directory or from node_modules (inernal pages like _app, _document)
• Only reading page runtime when reactRoot is enabled, reduce time for react 17 apps

[shuding]

Since we are checking reactRoot every time, I think it makes sense to pass nextConfig to the util and check that condition inside? It should make the logic a lot simpler.

[ijjk]

Failing test suites

Commit: 8a4c446

yarn testheadless test/integration/cli/test/index.test.js

• CLI Usage > info > should print output

Expand output

● CLI Usage › info › should print output

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "warn  - Latest canary version not detected, detected: \"12.1.3-canary.1\", newest: \"12.1.3-canary.2\".
        Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
        Read more - https://nextjs.org/docs/messages/opening-an-issue
"

  496 |       // warning will show so skip this check for the stable release
  497 |       if (pkg.version.includes('-canary')) {
> 498 |         expect(info.stderr || '').toBe('')
      |                                   ^
  499 |       }
  500 |       expect(info.stdout).toMatch(
  501 |         new RegExp(`

  at Object.<anonymous> (integration/cli/test/index.test.js:498:35)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
buildDuration	15.6s	15.7s	⚠️ +185ms
buildDurationCached	5.9s	6.1s	⚠️ +176ms
nodeModulesSize	467 MB	467 MB	⚠️ +809 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.201	3.193	-0.01
/ avg req/sec	780.96	782.97	+2.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.44	1.42	-0.02
/error-in-render avg req/sec	1735.6	1760.3	+24.7

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
925.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	28.4 kB	28.4 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	192 B	192 B	✓
amp-HASH.js gzip	309 B	309 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	3.05 kB	3.05 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	920 B	920 B	✓
image-HASH.js gzip	5.48 kB	5.48 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.7 kB	15.7 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
buildDuration	18.9s	19.3s	⚠️ +344ms
buildDurationCached	6.2s	6.3s	⚠️ +69ms
nodeModulesSize	467 MB	467 MB	⚠️ +809 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.144	3.188	⚠️ +0.04
/ avg req/sec	795.22	784.09	⚠️ -11.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.376	1.394	⚠️ +0.02
/error-in-render avg req/sec	1816.35	1793.86	⚠️ -22.49

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
925.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.8 kB	28.8 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.7 kB	72.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	179 B	179 B	✓
amp-HASH.js gzip	313 B	313 B	✓
css-HASH.js gzip	324 B	324 B	✓
dynamic-HASH.js gzip	3.04 kB	3.04 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	921 B	921 B	✓
image-HASH.js gzip	5.59 kB	5.59 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	2.33 kB	2.33 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
script-HASH.js gzip	388 B	388 B	✓
withRouter-HASH.js gzip	317 B	317 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	15.8 kB	15.8 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js page-runtime-resolving	Change
index.html gzip	529 B	529 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 7da3469