Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] updated styled-components #37856

Merged

Conversation

falsepopsky
Copy link
Contributor

@falsepopsky falsepopsky commented Jun 20, 2022

Example

  • added declaration file types for the used theme Create a declarations file
  • added custom styled component that wraps an <a> tag like the next js docs as example Next link DOCS
  • changed the ui page like the create-next-app examples

Dependencies

  • updated deps to latest
  • added types for SC => @types/styled-components
  • removed react-is, unused in this example

Example deploy

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

…mple and a custom styled component that wraps an <a> tag
@ijjk ijjk added the examples Issue/PR related to examples label Jun 20, 2022
@falsepopsky falsepopsky changed the title update deps and created declaration file types for the used theme exa… updated styled-components example Jun 20, 2022
@falsepopsky falsepopsky changed the title updated styled-components example [example] updated styled-components Jun 20, 2022
@falsepopsky falsepopsky changed the title [example] updated styled-components [Examples] updated styled-components Jun 20, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit eb9a500 into vercel:canary Jun 21, 2022
@falsepopsky falsepopsky deleted the feature/add-types-styledcomponents branch June 22, 2022 01:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants